-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-49347][R] Deprecate SparkR #47842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Vote is in progress so I mark it as a draft |
dongjoon-hyun
approved these changes
Aug 22, 2024
a851a98 to
118e5ce
Compare
allisonwang-db
approved these changes
Aug 22, 2024
Contributor
allisonwang-db
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 SparkR
xinrong-meng
approved these changes
Aug 26, 2024
Contributor
|
LGTM. Thanks @HyukjinKwon |
dongjoon-hyun
approved these changes
Aug 26, 2024
Member
Author
|
Merged to master. |
HyukjinKwon
added a commit
that referenced
this pull request
Aug 27, 2024
### What changes were proposed in this pull request? This PR is a followup of #47842 that sets `SPARK_TESTING` in Windows build. ### Why are the changes needed? The PR added a deprecation warning, and that fails Windows build. It should set `SPARK_TESTING` to work around the warning in the build (https://github.com/apache/spark/actions/runs/10563932730/job/29265243035). ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Will monitor the job after this PR is merged. ### Was this patch authored or co-authored using generative AI tooling? No Closes #47881 from HyukjinKwon/SPARK-49347-followup. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
Sep 14, 2024
### What changes were proposed in this pull request? This PR aims to update Spark documentation landing page (`docs/index.md`) for Apache Spark 4.0.0-preview2 release. ### Why are the changes needed? - [SPARK-45314 Drop Scala 2.12 and make Scala 2.13 by default](https://issues.apache.org/jira/browse/SPARK-45314) - #46228 - #47842 - [SPARK-45923 Spark Kubernetes Operator](https://issues.apache.org/jira/browse/SPARK-45923) ### Does this PR introduce _any_ user-facing change? No because this is a documentation-only change. ### How was this patch tested? Manual review. <img width="927" alt="Screenshot 2024-09-13 at 16 01 55" src="https://github.com/user-attachments/assets/bdbd0e61-d71a-41ca-aa1b-1b0805813a45"> <img width="911" alt="Screenshot 2024-09-13 at 16 02 09" src="https://github.com/user-attachments/assets/e13a6bba-2149-48fa-983d-c5399defdc70"> <img width="820" alt="Screenshot 2024-09-13 at 16 02 38" src="https://github.com/user-attachments/assets/721c7760-bc2e-444c-9209-174e3119c2b4"> ### Was this patch authored or co-authored using generative AI tooling? No. Closes #48113 from dongjoon-hyun/SPARK-49649. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
yaooqinn
pushed a commit
that referenced
this pull request
Feb 13, 2025
…make-distribution.sh` help ### What changes were proposed in this pull request? This PR aims to add `SparkR` deprecation info additionally to the following for developers. - `README.md` - `make-distribution.sh` help message ### Why are the changes needed? `SparkR` is deprecated properly by the following. - #47842 This PR adds a little more because `README.md` and `make-distribution.sh` are the starting point for downstream Spark distribution developers. ### Does this PR introduce _any_ user-facing change? No behavior change. Only the documentation and help message of developer script. ### How was this patch tested? Manual review. ``` $ dev/make-distribution.sh --help 2> /dev/null make-distribution.sh - tool for making binary distributions of Spark usage: make-distribution.sh [--name] [--tgz] [--pip] [--r] [--connect] [--mvn <mvn-command>] <maven build options> See Spark's "Building Spark" doc for correct Maven options. SparkR is deprecated from Apache Spark 4.0.0 and will be removed in a future version. ``` ### Was this patch authored or co-authored using generative AI tooling? No Closes #49931 from dongjoon-hyun/SPARK-51200. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Kent Yao <[email protected]>
yaooqinn
pushed a commit
that referenced
this pull request
Feb 13, 2025
…make-distribution.sh` help ### What changes were proposed in this pull request? This PR aims to add `SparkR` deprecation info additionally to the following for developers. - `README.md` - `make-distribution.sh` help message ### Why are the changes needed? `SparkR` is deprecated properly by the following. - #47842 This PR adds a little more because `README.md` and `make-distribution.sh` are the starting point for downstream Spark distribution developers. ### Does this PR introduce _any_ user-facing change? No behavior change. Only the documentation and help message of developer script. ### How was this patch tested? Manual review. ``` $ dev/make-distribution.sh --help 2> /dev/null make-distribution.sh - tool for making binary distributions of Spark usage: make-distribution.sh [--name] [--tgz] [--pip] [--r] [--connect] [--mvn <mvn-command>] <maven build options> See Spark's "Building Spark" doc for correct Maven options. SparkR is deprecated from Apache Spark 4.0.0 and will be removed in a future version. ``` ### Was this patch authored or co-authored using generative AI tooling? No Closes #49931 from dongjoon-hyun/SPARK-51200. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Kent Yao <[email protected]> (cherry picked from commit 80fb9d0) Signed-off-by: Kent Yao <[email protected]>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…make-distribution.sh` help ### What changes were proposed in this pull request? This PR aims to add `SparkR` deprecation info additionally to the following for developers. - `README.md` - `make-distribution.sh` help message ### Why are the changes needed? `SparkR` is deprecated properly by the following. - apache#47842 This PR adds a little more because `README.md` and `make-distribution.sh` are the starting point for downstream Spark distribution developers. ### Does this PR introduce _any_ user-facing change? No behavior change. Only the documentation and help message of developer script. ### How was this patch tested? Manual review. ``` $ dev/make-distribution.sh --help 2> /dev/null make-distribution.sh - tool for making binary distributions of Spark usage: make-distribution.sh [--name] [--tgz] [--pip] [--r] [--connect] [--mvn <mvn-command>] <maven build options> See Spark's "Building Spark" doc for correct Maven options. SparkR is deprecated from Apache Spark 4.0.0 and will be removed in a future version. ``` ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#49931 from dongjoon-hyun/SPARK-51200. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Kent Yao <[email protected]> (cherry picked from commit 69b2d4d) Signed-off-by: Kent Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to deprecate SparkR per the vote result: https://lists.apache.org/thread/3c8qxks26kqflsjh0gtjo3nldk686vtq
Why are the changes needed?
See the discussion in dev mailing list: https://lists.apache.org/thread/qjgsgxklvpvyvbzsx1qr8o533j4zjlm5
Does this PR introduce any user-facing change?
Yes, it deprecates SparkR.
How was this patch tested?
Manually checked the documentation.
Also tested with SparkR shell:
Was this patch authored or co-authored using generative AI tooling?
No.